Add Starred API, revised Watchers API and Improved Docs #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valtlfelipe
commented
Sep 17, 2014
valtlfelipe
commented
- Added Starred API for get starred repos, star an repo and unstar an repo for authenticated users.
- Revised Watchers API using a new endpoint as shown in the GitHub API.
- Improved Documentation | Added incomplete Activity documentation for Starred and Watchers API.
| return $this->get('user/starred', array( | ||
| 'page' => $page | ||
| )); | ||
| return new Starred($this->client); |
There was a problem hiding this comment.
Changing the return value of an existing method is a BC break
There was a problem hiding this comment.
true, i will fix this
|
Fixing the watchers API is already covered in #183 |
|
I just commited restoring back the method and creating a new one so it does not break the usage. |
|
|
||
|
|
||
| /** | ||
| * @Deprecated |
There was a problem hiding this comment.
you should write it as @deprecated Use watchers() instead
|
I just commited removing the unused class (I forgot to remove it from git) and updated the docblock's. |
|
|
||
|
|
||
| /** | ||
| * @Deprecated Use watchers() instead |
There was a problem hiding this comment.
could you use same lowercase as other docblocks?
There was a problem hiding this comment.
yeah, sorry about this. I saw you already fixed it! Thanks ;)
cursedcoder
added a commit
that referenced
this pull request
Sep 23, 2014
Add Starred API, revised Watchers API and Improved Docs
|
good job |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.